Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Fix group amino codec #13307

Merged
merged 4 commits into from
Sep 15, 2022
Merged

fix!: Fix group amino codec #13307

merged 4 commits into from
Sep 15, 2022

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Sep 15, 2022 •
edited
Loading

Description

Same PR as #13196, but for group's MsgSubmitProposal.

Thanks @aleem1314 for flagging this

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 marked this pull request as ready for review September 15, 2022 14:36
@amaury1093 amaury1093 requested a review from a team as a code owner September 15, 2022 14:36
@codecov
Copy link

codecov bot commented Sep 15, 2022 •
edited
Loading

Codecov Report

Merging #13307 (b6f627a) into main (4fe7797) will decrease coverage by 0.85%.
The diff coverage is 24.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13307      +/-   ##
==========================================
- Coverage   55.87%   55.02%   -0.86%     
==========================================
  Files         646      648       +2     
  Lines       54895    55356     +461     
==========================================
- Hits        30675    30457     -218     
- Misses      21762    22451     +689     
+ Partials     2458     2448      -10
Impacted Files Coverage Δ
baseapp/abci.go 67.01% <0.00%> (+2.59%) ⬆️
baseapp/grpcrouter.go 90.00% <ø> (ø)
baseapp/grpcrouter_helpers.go 25.00% <ø> (ø)
baseapp/grpcserver.go 1.72% <ø> (ø)
baseapp/msg_service_router.go 85.29% <ø> (+4.41%) ⬆️
baseapp/options.go 69.23% <ø> (+0.71%) ⬆️
client/cmd.go 57.73% <0.00%> (ø)
client/context.go 54.49% <0.00%> (-1.79%) ⬇️
client/flags/flags.go 19.35% <ø> (-0.32%) ⬇️
client/grpc_query.go 15.38% <ø> (+15.38%) ⬆️
... and 211 more

@amaury1093 amaury1093 enabled auto-merge (squash) September 15, 2022 15:55
@amaury1093 amaury1093 merged commit 340c01b into main Sep 15, 2022
@amaury1093 amaury1093 deleted the am/group-amino branch September 15, 2022 17:06
@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.46.x

mergify bot pushed a commit that referenced this pull request Nov 30, 2022
@amaury1093 @mergify
fix!: Fix group amino codec (#13307)
05e27cb 
* fix!: Fix group amino codec

* changelog

(cherry picked from commit 340c01b)

# Conflicts:
#	CHANGELOG.md
#	docs/core/encoding.md
#	x/auth/types/codec.go
#	x/auth/vesting/types/codec.go
#	x/authz/codec.go
#	x/bank/types/codec.go
#	x/crisis/types/codec.go
#	x/distribution/types/codec.go
#	x/evidence/types/codec.go
#	x/feegrant/codec.go
#	x/gov/codec/doc.go
#	x/gov/types/v1/codec.go
#	x/gov/types/v1beta1/codec.go
#	x/group/codec.go
#	x/group/simulation/operations_test.go
#	x/mint/types/codec.go
#	x/slashing/types/codec.go
#	x/staking/types/codec.go
#	x/upgrade/types/codec.go
@mergify mergify bot mentioned this pull request Nov 30, 2022
Closed
@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2022

backport release/v0.46.x

✅ Backports have been created

@ryanchristo ryanchristo mentioned this pull request Dec 12, 2022
Merged
19 tasks
ryanchristo pushed a commit to regen-network/cosmos-sdk that referenced this pull request Dec 14, 2022
@amaury1093 @ryanchristo
fix!: Fix group amino codec (cosmos#13307)
638d47e 
* fix!: Fix group amino codec

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

Assignees
No one assigned
Labels
C:Simulations C:x/auth C:x/authz C:x/bank C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/gov C:x/group C:x/mint C:x/slashing C:x/staking C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amaury1093 @julienrbrt @tac0turtle